Skip to content

[NONEVM-4924] [Offramp] ReceiveExecutor_Bounced should be bounce false #735

Merged
patricios-space merged 1 commit into
mainfrom
fix/offramp/set-bounce-false-for-ReceiveExecutor_Bounced
May 11, 2026
Merged

[NONEVM-4924] [Offramp] ReceiveExecutor_Bounced should be bounce false #735
patricios-space merged 1 commit into
mainfrom
fix/offramp/set-bounce-false-for-ReceiveExecutor_Bounced

Conversation

@patricios-space
Copy link
Copy Markdown
Collaborator

@patricios-space patricios-space commented May 8, 2026

NONEVM-4924

bounce: true can be missleading. Offramp doesn't handle ReceiveExecutor_Bounced bounced message.

Depends on #733

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OffRamp contract’s failure-notification messages (ReceiveExecutor_Bounced) to be sent with bounce: false, aligning behavior with the fact that OffRamp does not handle bounces for this message type.

Changes:

  • Set bounce: false when OffRamp sends ReceiveExecutor_Bounced in three failure paths (router route bounce, receiver bounce, and low-gas blocking).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread contracts/contracts/ccip/offramp/contract.tolk
@patricios-space patricios-space marked this pull request as ready for review May 8, 2026 18:45
@patricios-space patricios-space requested a review from a team as a code owner May 8, 2026 18:45
Base automatically changed from vv/revert-update-prices-value-bump to main May 11, 2026 13:28
@patricios-space patricios-space force-pushed the fix/offramp/set-bounce-false-for-ReceiveExecutor_Bounced branch from 057504a to 3aac2c2 Compare May 11, 2026 13:37
@patricios-space patricios-space merged commit a109ef2 into main May 11, 2026
35 checks passed
@patricios-space patricios-space deleted the fix/offramp/set-bounce-false-for-ReceiveExecutor_Bounced branch May 11, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants